Codecov Report

❗ No coverage uploaded for pull request base (develop@1054f37). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             develop    #381   +/-   ##
=========================================
  Coverage           ?   44.1%           
=========================================
  Files              ?     174           
  Lines              ?    1712           
  Branches           ?     187           
=========================================
  Hits               ?     755           
  Misses             ?     841           
  Partials           ?     116

This doesn't seem to open links like https://ns.link/emmaguthrie in the app on Android. The reason is that there is no route in the AndroidManifest.xml file for / and therefore never tries to open the app to get the slug. That's easy enough to add and I've tested it locally and it works, so I could add it here.

A bigger, more concerning issue is opening links like that in iOS. Android is easy because we allow all the links to come through and then handle them in the AndroidManifest.xml file. iOS doesn't work that way. Apple wants us to define all the routes up front in the apple-app-site-association file. Which means that if we want routes like this to work, we'd need to allow the / route ... I think. I don't feel great about that because then it would allow any and all links.

Thoughts? Is there a downside to just letting all the links through? Am I just thinking about this the wrong way?